> On Sep 18, 2019, at 06:53, Warner Losh <i...@bsdimp.com> wrote: > > > >> On Wed, Sep 18, 2019, 1:41 PM Kyle Evans <kev...@freebsd.org> wrote: >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper <yaneurab...@gmail.com> wrote: >> > >> > >> > > On Sep 17, 2019, at 18:58, Kyle Evans <kev...@freebsd.org> wrote: >> > > >> > > Author: kevans >> > > Date: Wed Sep 18 01:58:56 2019 >> > > New Revision: 352465 >> > > URL: https://svnweb.freebsd.org/changeset/base/352465 >> > > >> > > Log: >> > > googletest: default-disable on all of MIPS for now >> > > >> > > Parts of the fusefs tests trigger a bug in current versions of llvm: IR >> > > representation of some routine for the MIPS targets is a function with a >> > > large number of arguments. This then leads the compiler on an hour+ long >> > > goose chase, which is OK if you build the current tree but less-so if >> > > you're >> > > trying external toolchain or doing a universe build involving mips when >> > > it >> > > eventually gets switched over to LLVM. >> > > >> > > Better, accurate details can be found in LLVM PR43263. >> > >> > Uhhhhh... why not do this in tests/sys/... instead? >> >> Because there's still value in being able to easily enable these for >> building/running the complete set of tests through standard build >> infrastructure, but it's not worth adding a knob specifically for the >> fusefs tests. I also prefer the communication of it being an >> off-by-default option and easily deduced from src.conf(5) that this >> part of the build is default-disabled on mips/mips. > > > This is the right way to do this, imho...
I disagree: disabling a framework and all tests dependent on it because of compile times for a single test suite is the wrong approach. I would complain more loudly (for instance), if MK_TESTS were disabled on mips, just because of a build or test issue with a single test. This change throws the baby out with the bath water. The only reason why I’m not asking for a revert is that mips is a tier 2 arch which I haven’t verified, and the bath tub that’s being emptied is small, as many folks haven’t written GoogleTest tests yet in the src tree. -Enji _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
