On Tue, Dec 20, 2016 at 4:37 AM, Ravi Pokala <[email protected]> wrote: > -----Original Message----- >> From: <[email protected]> on behalf of Ian Lepore >> <[email protected]> >> Date: 2016-12-19, Monday at 11:20 >> To: Warner Losh <[email protected]>, Ravi Pokala <[email protected]> >> Cc: Sepherosa Ziehau <[email protected]>, Dimitry Andric >> <[email protected]>, src-committers <[email protected]>, >> "[email protected]" <[email protected]>, >> "[email protected]" <[email protected]> >> Subject: Re: svn commit: r310171 - head/sys/sys >> >> On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote: >>> >>> ... >>> >>> Are there other precedence for avoiding the SCN macros in the tree as >>> well, or is this new art? >>> >>> Warner >> >> There was another commit recently the fixed the same kind of scanf >> error by making the variable fit the scanf type (changing uint64_t to >> an explicit long long unsigned, iirc). I don't know if that alone >> counts as a precedent, but IMO it's a more palatible fix than the >> SCN/PRI ugliness. > > With all apologies to Churchill, SCN/PRI are the worst way to address this in > a machine-independent way, except for all the other ways that have been tried > from time to time. :-P >
If no objection comes, I'd commit the posted patch as it is tomorrow in my time. Thanks, sephe -- Tomorrow Will Never Die _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
