On 12/6/2017 4:53 PM, Hans Petter Selasky wrote:
> It would be nice if these utilities can be built standalone, outside the
> buildworld target aswell. I've suggested adding an "all-install" variant
> to make. Having to kick a buildworld to test-build contrib/ofed is quite
> overkill, and that is some of reasoning behind the current Makefile layout.

This is what buildworld+SUBDIR_OVERRIDE is for.  The following patch
also mitigates the need to install libraries for build testing which
I'll commit tomorrow:

> commit 7cce144e821cbf2f4e70711928a8945137700b35 (HEAD -> master)
> Author: Bryan Drewery <bdrew...@freebsd.org>
> Date:   Wed Dec 6 17:29:57 2017 -0800
> 
>     Look for libraries in OBJDIR when building outside of buildworld.
> 
>     This allows build testing more easily without establishing a sysroot
>     or installing the files.
> 
>     Sponsored by:   Dell EMC
> 
> diff --git share/mk/src.libnames.mk share/mk/src.libnames.mk
> index 2d172197ac53..fdd1a4866620 100644
> --- share/mk/src.libnames.mk
> +++ share/mk/src.libnames.mk
> @@ -359,7 +359,7 @@ LIB${_l:tu}?=       
> ${LIBDESTDIR}${LIBDIR_BASE}/libprivate${_l}.a
>  .endfor
> 
>  .for _l in ${_LIBRARIES}
> -.if ${_INTERNALLIBS:M${_l}}
> +.if ${_INTERNALLIBS:M${_l}} || !defined(SYSROOT)
>  LDADD_${_l}_L+=                -L${LIB${_l:tu}DIR}
>  .endif
>  DPADD_${_l}?=  ${LIB${_l:tu}}


-- 
Regards,
Bryan Drewery

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to