On 12/07/17 01:48, Bryan Drewery wrote:
7. We don't put FreeBSD Makefiles in the same directory as contributed
files. It's against the pattern. So moving contrib/ofed/usr.lib/* to
contrib/ofed/*/ is wrong. It complicates future merges of contrib code.
Really none of these Makefiles should be in contrib/ofed - the proper
thing would be to move them out, not to inline them with the contributed
code.
Hi,
At the moment Mellanox is maintaining this code. Importing vendor code
must be merged carefully using graphical tools like "meld". There is no
simple C&P at the moment. Several of the utilities in OFED use automake
or cmake to build. The Makefiles for FreeBSD must be created manually.
This also include the associated config.h files.
All the OFED utilities have been re-organized source-wise in upstream
GITs since the last OFED user-space update. I'd like the Makefiles to
stay in a similar tree as the source tree, so that figuring out which
Makefile pull sources from which directory is more trivial instead of
having to look into each and every one of them.
Finally, Mellanox has sent out several mails to infinib...@freebsd.org
and curr...@freebsd.org warning and telling we are going to merge. I've
waited one week extra for input, but it has all been silent. That
someone now should jump and say everything is wrong with the Makefiles
and build infrastructure in OFED is simply not fair. It would be really
helpful to me if you could be more responsive in the few weeks behind or
at least say you're busy or on vacation.
--HPS
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
