| From: Paul Wouters <[email protected]> | commit 6c082c86a1992fbaf3a19101419db4942f5729eb | Author: Paul Wouters <[email protected]> | Date: Sat Apr 5 13:12:39 2014 -0400 | | Move TIMETOA_BUF and UNDEFINED_TIME to pluto_constants.h | | It has nothing to do with the functions offered in lswtime.[ch] and | reduced the number of includes requires for lswtime.h
Actually, I think those #defines were in a good neighbourhood. TIMETOA_BUF is the size of buffer needed for the output of timetoa so it should be defined where timetoa is declared. Similarly UNDEFINED_TIME was a distinct time_t value (we hope! -- this assumption is a bit dubious) and so makes sense being defined near where now() is declared. Or, if different, where other time_t thingees are declared. It may well be that the include/lswtime.h should be refactored. But I think that those affinities should be respected. | commit 4042977049e5a2e03d156351f77b5103703a2f00 | Author: Paul Wouters <[email protected]> | Date: Sat Apr 5 13:11:28 2014 -0400 | | pluto: Fix two occurances forgotten in the cert.type -> cert.ty rename Thanks. I don't know what happened there. In my editing, I had changed not only "type" to "ty" but "0" to CERT_NONE. I wonder what other chnages I've lost in my witless gitting. _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
