On Sun, Sep 24, 2017 at 05:05:42PM +0000, Aviv Heller wrote: > > coverity-detected anomalies are sometimes subtle. So I looked at this > > code and found a couple of bugs. I also did some tidying. But no > > testing! > > > > Aviv, Antony: please have a look at commit > > f7aaa80198851ef71da4be8dc54e816f7064e29a > > Hi Hugh, Antony, > > Hugh, thanks for bringing this up, there are indeed a few bugs in the code. > > > Note: % 31 is almost never correct. I think that in this code, + 31 is > > also wrong.
Hugh why did you think + 31 was wrong? Are there any documention about this? -antony _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
