On 18 April 2018 at 11:09, Antony Antony <[email protected]> wrote: > thanks Andrew. Once the dust settle, this would be a great simplification and > help merging easier.
yea, let the dust settle; I'm in no hurry to remove the code juggling NP - I'm sure some unexpected unknown will crop up. > On Tue, Apr 17, 2018 at 09:07:02PM -0400, Andrew Cagney wrote: >> For instance, code like this: >> >> .np = IMPAIR(ADD_BOGUS_PAYLOAD_TO_SA_INIT) ? >> ISAKMP_NEXT_v2BOGUS : >> (vids != 0) ? ISAKMP_NEXT_v2V : ISAKMP_NEXT_v2NONE, > > in IKEv2 code, can we also remove np parameter, say in the ship/send > functions? > e.g the parameter to ikev2_out_nat_v2n() Yes. But just passing 0 should also work. > np in justship_v2KE() > > ditching np juggling code could be a one time pain:), but probably worth it > in the long term. _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
