On 19 April 2018 at 14:16, D. Hugh Redelmeier <[email protected]> wrote: > I've not looked at the code. But that won't stop me commenting :-) > > I think that this change is a good idea. > > One advantage of the old code was that the logging of the outgoing payload > displayed the correct next payload field. For that reason, I'd only use > the new mechanism when it saves code (i.e. when the field requires > computation). That computation is error-prone since it (usually) > duplicates, with some chance of error, some other logic. > > | ft_mnp: > | save the message header's next payload field location in the > | message digest, ready for ...
Wrong term, It's saved in the message's struct packet_byte_stream aka pb_stream. Andrew _______________________________________________ Swan-dev mailing list [email protected] https://lists.libreswan.org/mailman/listinfo/swan-dev
