On Fri, Mar 24, 2017 at 11:55 PM, Carl Brown1 <[email protected]> wrote:
> Maybe this is the core of this whole issue. In my experience, the very > easiest part of the software development process is getting it to compile. > The *real effort* doesn't even start until after that's completed. > > If I thought that "case-sensitive find-and-relace" was "the tricky thing" > in developing software, and all I had to care about was avoiding "invalid > redeclarations anywhere" then this proposal might seem like a good idea to > me, too. > My point is that, in rolling back the specific portion of SE-0025, case-sensitive find-and-replace will be the trickiest thing in most codebases, save those that result in invalid redeclarations. The behavior of the resultant code is, unless I'm mistaken, provably unchanged. This in itself bolsters the case that the distinction between `fileprivate` and `private` did not really carry its own weight. Indeed, if I thought that there would be an unknowable amount of effort required to migrate code, then I would be more hesitant about rolling back SE-0025. That said, I'm curious as to how your argument would not apply to literally every single source-breaking change. > > -Carl > > > [image: Inactive hide details for Xiaodi Wu via swift-evolution > ---03/24/2017 11:10:54 PM---On Fri, Mar 24, 2017 at 10:47 PM, Xiaodi Wu]Xiaodi > Wu via swift-evolution ---03/24/2017 11:10:54 PM---On Fri, Mar 24, 2017 at > 10:47 PM, Xiaodi Wu <[email protected]> wrote: > As Chris has said in > the > > From: Xiaodi Wu via swift-evolution <[email protected]> > To: Drew Crawford <[email protected]>, Jonathan Hull <[email protected] > > > Cc: swift-evolution <[email protected]> > Date: 03/24/2017 11:10 PM > Subject: Re: [swift-evolution] [Review] SE-0159: Fix Private Access Levels > Sent by: [email protected] > ------------------------------ > > > On Fri, Mar 24, 2017 at 10:47 PM, Xiaodi Wu <*[email protected]* > <[email protected]>> wrote: > > Update: with the caveat that corelibs-foundation tests are incomplete, it > took me about 15 mins to migrate all uses of private to fileprivate. The > tricky thing is that one has to do case-sensitive find-and-replace, and to > replace all instances of "filefileprivate" in a second round. It does not > appear that corelibs-foundation actually uses new `private` in a way that > migrating to `fileprivate` results in invalid redeclarations anywhere. > > > >
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
