Excellently written proposal, sensible motivation. Only nit is that `with` is not required and is better off removed, IMO. Here's why:
* "swap a and b" and "swap a with b" are equivalent statements * there's no reason to use one phrasing for the free function and another with this method; the difference is in taking indices vs. inout values, but the relationship between a and b is preserved * the former spelling emphasizes the symmetry of the operation, which I believe is in line with API naming guidelines on labels * the former spelling is also terser On Tue, Apr 25, 2017 at 13:32 Ted Kremenek via swift-evolution < [email protected]> wrote: > Hello Swift community, > > The review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and > runs through *April 28, 2017*. > > The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at: > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the > review manager. When replying, please try to keep the proposal link at the > top of the message: > > Proposal link: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md > Reply text > > Other replies > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > - What is your evaluation of the proposal? > - Is the problem being addressed significant enough to warrant a > change to Swift? > - Does this proposal fit well with the feel and direction of Swift? > - If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > - How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at: > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > Ted (Review Manager) > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution >
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
