> On Apr 26, 2017, at 6:36 PM, Xiaodi Wu via swift-evolution > <[email protected]> wrote: > > On Wed, Apr 26, 2017 at 4:06 PM, Howard Lovatt via swift-evolution > <[email protected] <mailto:[email protected]>> wrote: > review of SE-0173 "Add MutableCollection.swap(_:with:)" > > What is your evaluation of the proposal? > Good idea. Reads better than current global swap. > Is the problem being addressed significant enough to warrant a change to > Swift? > Probably; It will become significant once control over ARC added, though not > needed just yet. > Does this proposal fit well with the feel and direction of Swift? > Yes. The global functions do not sit well with Swift. Methods read much > better. Could just eliminate current swap and not replace it though. You can > write `(a[i], a[j]) = (a[j], a[i])` instead. > > Source compatibility is a serious goal now. There's no harm in the current > `swap`, and I use it. This is no rationale for breaking existing code.
There are also performance — and, under ownership, eventually semantic — benefits to using swap over the tuple-assignment idiom. John. > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? > Yes. People write similar functions in Java, though not in standard library. > How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? > Quick read > > > -- Howard. > > On 26 Apr 2017, at 4:32 am, Ted Kremenek <[email protected] > <mailto:[email protected]>> wrote: > >> review of SE-0173 "Add MutableCollection.swap(_:with:)" begins now and runs >> through April 28, 2017. >> >> The proposal is available here: >> >> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md >> >> <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md> >> Reviews are an important part of the Swift evolution process. All reviews >> should be sent to the swift-evolution mailing list at: >> >> https://lists.swift.org/mailman/listinfo/swift-evolution >> <https://lists.swift.org/mailman/listinfo/swift-evolution> >> or, if you would like to keep your feedback private, directly to the review >> manager. When replying, please try to keep the proposal link at the top of >> the message: >> >> Proposal link: >> >> https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md >> >> <https://github.com/apple/swift-evolution/blob/master/proposals/0173-swap-indices.md> >> Reply text >> >> Other replies >> What goes into a review? >> >> The goal of the review process is to improve the proposal under review >> through constructive criticism and, eventually, determine the direction of >> Swift. When writing your review, here are some questions you might want to >> answer in your review: >> >> What is your evaluation of the proposal? >> Is the problem being addressed significant enough to warrant a change to >> Swift? >> Does this proposal fit well with the feel and direction of Swift? >> If you have used other languages or libraries with a similar feature, how do >> you feel that this proposal compares to those? >> How much effort did you put into your review? A glance, a quick reading, or >> an in-depth study? >> M >> > > _______________________________________________ > swift-evolution mailing list > [email protected] <mailto:[email protected]> > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > > > _______________________________________________ > swift-evolution mailing list > [email protected] <mailto:[email protected]> > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution>
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
