> On 20 Dec 2017, at 9:58 am, Ted Kremenek via swift-evolution > <firstname.lastname@example.org> wrote: > > The review of "SE 0192 - Non-Exhaustive Enums" begins now and runs through > January 3, 2018. > > The proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0192-non-exhaustive-enums.md > Reviews are an important part of the Swift evolution process. All review > feedback should be sent to the swift-evolution mailing list at: > > https://lists.swift.org/mailman/listinfo/swift-evolution > or, if you would like to keep your feedback private, directly to the review > manager. > > When replying, please try to keep the proposal link at the top of the message: > > Proposal link: > https://github.com/apple/swift-evolution/blob/master/proposals/0192-non-exhaustive-enums.md > ... > Reply text > ... > Other replies > What goes into a review of a proposal? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. > > When reviewing a proposal, here are some questions to consider: > > What is your evaluation of the proposal? > +1. I was involved in some of the earlier discussions and discussed the pros and cons of each way, tossed and turned, and to be honest, like “public vs open” I think this comes out to “it’s the best compromise”.
We need to handle additional cases safely, and people need to think carefully as it will be a compatibility issue to leave new enum cases unhandled. This proposal sums this up well. > Is the problem being addressed significant enough to warrant a change to > Swift? > Yes. This is an important change. > Does this proposal fit well with the feel and direction of Swift? > Feel? Not 100%, but this is a compromise for compatibility. Direction? Yes. It is in a direction to allow ABI compatibility, so yes. > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? > I’ve dealt with not handling extra cases in Obj-C, and handling the compatibility issues with current Swift code. > How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? > Somewhere between a quick reading and a in-depth study. This was one of my bugbears, something I knew we needed to sort out and I’m glad Jordan picked it up. I was involved in the conversation, and churned through the issues there in the earlier discussions. > Thanks, > Ted Kremenek > Review Manager > _______________________________________________ > swift-evolution mailing list > email@example.com > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list firstname.lastname@example.org https://lists.swift.org/mailman/listinfo/swift-evolution