Hello Alexander, all,
please find the new version here:
http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.03/
Please see comments inline.
Regards,
- Vlad
On 1/21/2013 05:14 PM, Alexander Scherbatiy wrote:
Some small comments:
- Keys Up and Down do not work with WindowsLookAndFeel and enabled
ComboBox.noActionOnKeyNavigation property. Is it expected behavior?
The fix was changed so now it will disable actionPerformed events only
when the drop-down list is visible. This will eliminate Windows L&F
issue. All LAFs will work in the same manner.
- Method getNextIndex from the BasicComboBoxUI class is private, so
it is possible to pass the ui variable as an argument rather to obtain
it one more time
Fixed.
- Cancel action does not set the ui.listBox selected index to the
initial state. However, it seems that it works correct when the popup
is opened next time.
Could you please elaborate more on this? I'm afraid I didn't quite
understand the issue here...
Thanks,
Alexandr.
On 1/17/2013 5:33 PM, Vladislav Karnaukhov wrote:
Hello,
please review a new version of the fix:
http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.02/
Support for VK_PAGE_DOWN/VK_PAGE_UP and VK_HOME/VK_END keys was added;
test routine was altered accordingly.
Regards,
- Vlad
