- key == PAGE_UP / (key == PAGE_DOWN)
Are ui.listBox.getSelectedIndex() and comboBox.getSelectedIndex() the
same when the "ComboBox.noActionOnKeyNavigation"
property is unset? If so, only the ui.listBox.getSelectedIndex() can
be used for both cases.
- key == HIDE
I would suggest to set the ui.listBox.selected index back to the
comboBox.selected index to prevent some issues where these two indices
are expected to be the same.
Thanks,
Alexandr.
On 1/30/2013 2:36 PM, Vladislav Karnaukhov wrote:
Hello Alexandr, all,
please find a new version here:
http://cr.openjdk.java.net/~vkarnauk/4199622/webrev.05/
On 1/29/2013 07:26 PM, Alexander Scherbatiy wrote:
- WindowsLookAndFeel and ComboBox.noActionOnKeyNavigation property is
set
Press down. Next item is selected and the action listener is
invoked. Is it expected behavior (the drop down list is not shown in
this case)?
Yes, it's expected. Customer would like to turn off event firing only
when popup is open. To keep consistency over different LAFs, I only
handle the new flag when drop-down is showing. Under Windows, if drop
list wasn't shown, JComboBox will work as usual even if the flag was set.
- It seems that the code below can have a shorter form:
if
(UIManager.getBoolean("ComboBox.noActionOnKeyNavigation")) {
if (!comboBox.isPopupVisible()) {
comboBox.setSelectedIndex(si+1);
}
} else {
comboBox.setSelectedIndex(si+1);
}
->
if ( !(UIManager.getBoolean("ComboBox.noActionOnKeyNavigation") &&
comboBox.isPopupVisible()) ) {
comboBox.setSelectedIndex(si+1);
}
Agree; fixed.
- doTest() method in the test throws some exception. It can throw robot
and toolkit exceptions as well.
Agree; fixed.
Thanks,
Alexandr.
