Looks fine.
On 30.09.15 14:45, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/30/2015 1:01 PM, Rajeev Chamyal wrote:
Hello Alexander,
Thanks for the review. I have updated webrev as per review comments.
Bug: https://bugs.openjdk.java.net/browse/JDK-8067346
Webrev: http://cr.openjdk.java.net/~psadhukhan/rajeev/8067346/webrev.02/
Regards,
Rajeev Chamyal
-----Original Message-----
From: Alexander Scherbatiy
Sent: Tuesday, September 29, 2015 6:59 PM
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Alexander Zvegintsev; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-8067346: Swing submenu has a
changed starting offset
On 9/29/2015 12:38 PM, Rajeev Chamyal wrote:
Hello All,
Please review the following updated webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8067346
Webrev:
http://cr.openjdk.java.net/~psadhukhan/rajeev/8067346/webrev.01/
Verified the fix on windows10 and windows8.
bug8067346.java.html
66 try {
67 // set windows look and feel
68 UIManager.setLookAndFeel(LOOK_FEEL);
69 } catch (UnsupportedLookAndFeelException e) {
70 System.out.println("Windows look and feel is not
supported");
71 } catch (ClassNotFoundException e) {
72 } catch (InstantiationException e) {
73 } catch (IllegalAccessException e) {
74 }
Is the test designed to work only with Windows L&F? If yes, it
needs just to pass the test instead of running it with the default one
when the Windows L&F is not available.
Thanks,
Alexandr.
Regards,
Rajeev Chamyal
-----Original Message-----
From: Sergey Bylokhov
Sent: Wednesday, September 23, 2015 11:44 PM
To: Rajeev Chamyal; Alexander Zvegintsev; swing-dev@openjdk.java.net;
Alexander Scherbatiy
Subject: Re: Review request for JDK-8067346: Swing submenu has a
changed starting offset
Hi, Rajeev.
Can you check Windows 10 as well? Thanks.
On 22.09.15 13:09, Rajeev Chamyal wrote:
Hi,
Please review the following fix for jdk9:
Bug:https://bugs.openjdk.java.net/browse/JDK-8067346
Webrev:
http://cr.openjdk.java.net/~psadhukhan/rajeev/8067346/webrev.00/
WindowsLookAndFeel.java overrides basic look and feel properties
based on different OS versions XP, Vista etc.
Current implementation is applying Vista defaults to Windows7 as
well and as a result submenu on windows7 has changed offset.
Added checks in WindowsLookAndFeel.java to skip Vista menu defaults
for Windows7.
Verified changes on Netbeans9 Dev build and SwingSet2 applications.
Regards,
Rajeev Chamyal
--
Best regards, Sergey.
