This test expects that the headful toolkit/GEnvironment will throw an error when it tries to connect to x11 using broken DISPLAY. But if "java.awt.headless" is passed then our headless toolkit/HeadlessEnvironment will skip validation of "DISPLAY".

On 30/01/2018 11:57, Phil Race wrote:
You added @headful to BadDisplayTest, but also added this logic - why ?


  public class BadDisplayTest{
     public static void main(String[] args) {
+       if (Boolean.getBoolean("java.awt.headless")) {
+           return;
+       }

-phil.

On 01/30/2018 11:47 AM, Sergey Bylokhov wrote:
Hello.
Please review small test cleanup for jdk11.

 - "@key headful" was added to some tests which requires DISPLAY/xorg/gtk/gnome etc.  - Some swing tests were updated to skip unsupported look and feels, for example GTK LookAndFeel can be installed(bundled) but is not necessary supported.

The final goal of this and some other future fixes is to run all non-headfull tests in parallel and speedup the tests execution.

Bug: https://bugs.openjdk.java.net/browse/JDK-8196196
Webrev can be found at: http://cr.openjdk.java.net/~serb/8196196/webrev.02/





--
Best regards, Sergey.

Reply via email to