Approved.
-phil.
On 2/2/18, 10:15 PM, Sergey Bylokhov wrote:
I do not know such syntax. But the easiest way to find such tests is
to run them using "java.awt.headless". The open tests are mostly
cleaned already. I'll start to update closed soon.
On 30/01/2018 12:06, Phil Race wrote:
PS .. I have a question about identifying headful tests.
I assume that jtreg itself knows nothing about the meaning of @key
headful .. it
just knows how to obey your command line option of -k:'!headful'
Many of the automated tests use applets. These would seem like they
are all headful ..
How would one do the same for excluding applets without tediously
adding this keyword.
Is there jtreg syntax to exclude '.*html' ? Which might be one way to
do it.
-phil.
On 01/30/2018 11:57 AM, Phil Race wrote:
You added @headful to BadDisplayTest, but also added this logic - why ?
public class BadDisplayTest{
public static void main(String[] args) {
+ if (Boolean.getBoolean("java.awt.headless")) {
+ return;
+ }
-phil.
On 01/30/2018 11:47 AM, Sergey Bylokhov wrote:
Hello.
Please review small test cleanup for jdk11.
- "@key headful" was added to some tests which requires
DISPLAY/xorg/gtk/gnome etc.
- Some swing tests were updated to skip unsupported look and
feels, for example GTK LookAndFeel can be installed(bundled) but is
not necessary supported.
The final goal of this and some other future fixes is to run all
non-headfull tests in parallel and speedup the tests execution.
Bug: https://bugs.openjdk.java.net/browse/JDK-8196196
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8196196/webrev.02/
