+1
Regards
Prasanta
On 3/15/2018 4:34 PM, Pankaj Bansal wrote:
Hi Sergey/Prasanta,
Thanks for the review.
I have incorporated the review comments given by Sergey, Prasanta and Joe (in
the CSR).
I have created the CSR https://bugs.openjdk.java.net/browse/JDK-8199395. Please
have a look at the CSR as well.
Webrev:
http://cr.openjdk.java.net/~pbansal/8074286/webrev.01/
Regards,
Pankaj Bansal
-----Original Message-----
From: Prasanta Sadhukhan
Sent: Tuesday, March 13, 2018 1:40 PM
To: Pankaj Bansal; swing-dev@openjdk.java.net
Cc: Sergey Bylokhov
Subject: Re: <Swing Dev> [11] [JDK-8074286] : Add getSelectedIndices() to
ListSelectionModel
Hi Pankaj,
Looks good to me, only thing I have some reservations is
JList.getSelectedValues is deprecated since jdk7, so in my opinion, we should
not modify it. Please add noreg-cleanup label to JBS.
Regards
Prasanta
On 3/9/2018 6:47 AM, Sergey Bylokhov wrote:
Hi, Pankaj.
The fix looks fine, please add @since tag for the new methods in CSR.
On 02/02/2018 09:06, Pankaj Bansal wrote:
Hi All,
Please review a fix for the Enhancement. I will raise a CSR after
technical evaluation.
Enhancement:
https://bugs.openjdk.java.net/browse/JDK-8074286
Webrev:
http://cr.openjdk.java.net/~pbansal/8074286/webrev.00/
The enhancement requests to add getSelectedIndices function to
ListSelectionModel Interface as same function with duplicate
implementation is being used in JList, JTable and
DefaultTableColumnModel.
I have also added the getSelectedItemsCount function in
ListSelectionModel, as this is also being used at multiple places
with same implementation.
JList.getSelectedValues and JList.getSelectedValuesList are also
modified to use getSelectionIndices instead of replicating the same
code.
Regards,
Pankaj Bansal
