Hi all, as a long time user of Swing and as a person who maintains a very huge ( > 3M lines of code) Swing-based application I would like vote against this change.
Could you please explain me which bug this change tries to solve? The so called duplicate code is not a bug and lambdas are not the holy grail. Just because lambdas exists it does not mean we should change every piece of code to use it. Your change will introduce a performance regression to every application that makes huge use of JLists and fires many events. Best regards, Andrej Golovnin On Fri, Apr 6, 2018 at 11:59 AM, Krishna Addepalli <krishna.addepa...@oracle.com> wrote: > Hi Pankaj, > > > > Thanks for your review. Here is the updated webrev: > http://cr.openjdk.java.net/~kaddepalli/8201173/webrev01/ > > > > Krishna > > From: Pankaj Bansal > Sent: Friday, April 6, 2018 3:04 PM > To: Krishna Addepalli <krishna.addepa...@oracle.com>; > swing-dev@openjdk.java.net > Subject: RE: <Swing Dev> [11] [JDK-8201173] Remove duplicated code in > AbstractListModel class > > > > Hi Krishna, > > > > The code changes look fine to me. > > Just one suggestion. I think you don’t need to create custom UpdateFunction > functional Interface here. Java has BiConsumer functional interface, which > does what you are trying to do here. > > > > Regards, > > Pankaj Bansal > > > > From: Krishna Addepalli > Sent: Thursday, April 5, 2018 9:09 PM > To: swing-dev@openjdk.java.net > Subject: <Swing Dev> [11] [JDK-8201173] Remove duplicated code in > AbstractListModel class > > > > Hi All, > > Please review a fix for > > JDK-8201173: https://bugs.openjdk.java.net/browse/JDK-8201173 > > Webrev: http://cr.openjdk.java.net/~kaddepalli/8201173/webrev00/ > > > > There is the duplication of code in fireContentsChanged, fireIntervalAdded, > fireIntervalRemoved functions, barring an int parameter and a function call. > > Moved the common code into a function called fireUpdates, and defined a > functional interface, so that each function can pass its own lambda that > does the requisite function call. > > > > I have run the tests for JList and JComboBox and observed no new failures. > > > > Thanks, > > Krishna
