Hi Andrej, Appreciate for the quick review. Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/4842658/webrev01/
Thanks, Krishna -----Original Message----- From: Andrej Golovnin <andrej.golov...@gmail.com> Sent: Monday, April 9, 2018 3:15 PM To: Krishna Addepalli <krishna.addepa...@oracle.com> Cc: swing-dev@openjdk.java.net Subject: Re: <Swing Dev> [11][JDK-4842658] RFR: DefaultListModel and DefaultComboBoxModel should support addAll (Collection c) Hi Krishna, > Please review a simple fix for enhancement: > > JDK-4842658: https://bugs.openjdk.java.net/browse/JDK-4842658 > > Webrev: http://cr.openjdk.java.net/~kaddepalli/4842658/webrev00/ > > CSR: https://bugs.openjdk.java.net/browse/JDK-8201289 src/java.desktop/share/classes/javax/swing/DefaultComboBoxModel.java 195 fireIntervalAdded(this, startIndex, getSize()); It should be: 195 fireIntervalAdded(this, startIndex, getSize() - 1); 221 fireIntervalAdded(this, index, index + c.size()); It should be: 221 fireIntervalAdded(this, index, index + c.size() - 1); src/java.desktop/share/classes/javax/swing/DefaultListModel.java 574 if(c.isEmpty()) { There should be a space after 'if'. Best regards, Andrej Golovnin
