90 checkInteractionOnDispaly();
239 private void checkInteractionOnDispaly() {
typo in the name here.
-phil.
On 05/01/2018 10:33 PM, Vikrant Agarwal wrote:
Hi Phil,
Please review this new Swingset client sanity test.
Best Regards,
Vikrant
-----Original Message-----
From: Vikrant Agarwal
Sent: Tuesday, April 10, 2018 6:54 PM
To: Sergey Bylokhov <sergey.bylok...@oracle.com>; swing-dev@openjdk.java.net
Cc: Aleksandre Iline <alexandre.il...@oracle.com>
Subject: Re: <Swing Dev> [11]JDK-8200605: Create test for GridBagLayoutDemo
Hi Sergey,
Thanks for the feedback, this failure was due to a bug in Mac,
Component.getLocation() was giving an incorrect/inconsistent initial value when
the component is located at (0,0). I have filed a bug for this issue:
https://bugs.openjdk.java.net/browse/JDK-8201364 .
I have also updated the test to prevent JDK-8201364 from affecting the test.
Updated Webrev: http://cr.openjdk.java.net/~vagarwal/8200605/webrev.1/
Why we did not see this in our SBR?
I had very recently added this check and this was not sync'd with SBR code.
Best Regards,
Vikrant
-----Original Message-----
From: Sergey Bylokhov
Sent: Saturday, April 07, 2018 4:38 AM
To: Vikrant Agarwal <vikrant.v.agar...@oracle.com>; swing-dev@openjdk.java.net
Cc: Aleksandre Iline <alexandre.il...@oracle.com>
Subject: Re: <Swing Dev> [11]JDK-8200605: Create test for GridBagLayoutDemo
Hi, Vikrant.
I tried to run the new test but it fails on my local system(macos):
===============================================
sanity/client/SwingSet/src/GridBagLayoutDemoTest.java
Total tests run: 4, Failures: 1, Skips: 0
===============================================
----------System.err:(16/1069)----------
Error:
"Wait "Component reaches location between :java.awt.Point[x=0,y=0]and
java.awt.Point[x=0,y=0]" state to be reached (ComponentOperator.WaitStateTimeout)" action
has not been produced in
60001 milliseconds
java.lang.Exception: failures: 1
at
com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:96)
at
com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at
com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:115)
at java.base/java.lang.Thread.run(Thread.java:831)
JavaTest Message: Test threw exception: java.lang.Exception: failures: 1
JavaTest Message: shutting down test
On 03/04/2018 03:10, Vikrant Agarwal wrote:
Hi All,
Please review this new test for SwingSet GridBagLayoutDemo:
Webrev: http://cr.openjdk.java.net/~vagarwal/8200605/webrev.0/
Bug: https://bugs.openjdk.java.net/browse/JDK-8200605
Summary: This adds an automated test for SwingSet GridBagLayoutDemo
for all the available look and feels.
We have set up Same Binaries Run to check for stability and this test
is consistently passing for Linux, Mac and Windows for all the look and feels.
Best Regards,
Vikrant
--
Best regards, Sergey.
