One thing from 1st look...
Every time installListeners is called, it instantiates SelectPreviousBtn
and SelectNextBtn which is a inner class (and not a static class) and it
has a strong reference to AquaButtonRadioUI so it may not be garbage
collected and can cause a leak.
Regards
Prasanta
On 8/11/2018 8:51 PM, Krishna Addepalli wrote:
Hi All,
Please review a fix for JDK-8208640:
https://bugs.openjdk.java.net/browse/JDK-8208640
Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/
<http://cr.openjdk.java.net/%7Ekaddepalli/8208640/webrev00/>
The problem is that the arrow key navigation for Aqua L&F was not
implemented, which is why neither the tab keys nor the arrow keys were
allowing to navigate through the radio buttons through a button group.
Proposed fix is to copy the implementation from Basic L&F into Aqua
L&F. Also fixed the test that was written to include the Aqua L&F to
be tested, and it passes on Mac successfully.
Thanks,
Krishna
