On 10/10/2018 21:43, Philip Race wrote:
This then seems like only a partial solution and not exactly a step to the 
complete solution.
Maybe we can push this fix but acknowledge it is just a bandage until the right 
solution.
So is there a plan to fix this so we can announce a table as a table - and 
announce
row & column names - rather than treat it as a grid ?

Yes, as described in the starting email it is not complete. We will need to 
update this, so the jtable without the column/row headers will be appeared as a 
grid(as in current fix), and the jtable with headers will be appeared as a 
table. So the current code will not be dropped.

What does it take to fix it properly ?

I'll start to working on it after complete some other related things, like 
jtree which is also complete not implemented.


-phil.

On 10/3/18, 5:56 PM, Sergey Bylokhov wrote:
On 02/10/2018 17:50, Philip Race wrote:
1) Why was "Table" wrong ? And why is "Grid" right ?

It is not wrong, but it requires a little bit different api to be used. For 
example the table have an options to read the rows/columns headers.
But the grid may work based on our current implementation(which were added for 
lists). This is a current limitation.


2) What was the purpose of that anyway without the code to back it up like :

+ } else if ([javaRole isEqualToString:@"table"]) {
+ newChild = [TableAccessibility alloc]; 3)

The code above creates an object of TableAccessibility which is our class. This 
class provide support for the count of columns/rows in the grid.

+ AccessibleTable table =
ac.getAccessibleTable(); Could table ever be null here ?

It should not be null for our tables, but it could be null for some custom 
components:
http://cr.openjdk.java.net/~serb/8133713/webrev.01


-phil.

On 8/29/18, 3:03 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk12.

Bug: https://bugs.openjdk.java.net/browse/JDK-8133713
Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00

This fix provides the minimal support of accessibility(VoiceOver) for JTable.

The table will be represented as a grid. The user will get audio information 
about:
 - number of columns
 - number of rows
 - the selected cells
 - the description of the whole table
 - the text in the current cell

The user will be able to interact with the table(select/deselect cells.)

Example and fix limitations are provided in the bug:
https://bugs.openjdk.java.net/browse/JDK-8133713?focusedCommentId=14207364&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14207364






--
Best regards, Sergey.

Reply via email to