Its looks okay. Lets wait for Sergey’s inputs on the same. And I think it needs CSR also.
Thanks, Jay > On 22-Nov-2019, at 3:04 PM, Tejpal Rebari <[email protected]> wrote: > > Hi Jay, > I have appended the text instead of replacing it, > and also updated the SelectionModel methods. > > Please find the updated webrev : > http://cr.openjdk.java.net/~trebari/swing/7020860/webrev1/ > <http://cr.openjdk.java.net/~trebari/swing/7020860/webrev1/> > > Thanks > Tejpal > >> On 18-Nov-2019, at 1:00 PM, Jayathirth D V <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi Tejpal, >> >> I think Sergey has given more inputs on the present change that you have at : >> http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006815.html >> <http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006815.html> >> and http://mail.openjdk.java.net/pipermail/swing-dev/2017-June/007495.html >> <http://mail.openjdk.java.net/pipermail/swing-dev/2017-June/007495.html> >> >> Apart from this changes are fine. >> >> Thanks, >> Jay >> >> From: Tejpal Rebari >> Sent: Thursday, October 31, 2019 1:55 PM >> To: [email protected] <mailto:[email protected]> >> Subject: <Swing Dev> [14] RFR JDK-7020860 - BasicTreeUI contains >> getters/setters with unclear spec >> >> Hi All, >> Please review the following fix for JDK 14. >> >> Bug : https://bugs.openjdk.java.net/browse/JDK-7020860 >> <https://bugs.openjdk.java.net/browse/JDK-7020860> >> Webrev : http://cr.openjdk.java.net/~trebari/swing/7020860/webrev0/ >> <http://cr.openjdk.java.net/~trebari/swing/7020860/webrev0/> >> >> Issue : Class javax.swing.plaf.basic.BasicTreeUI contains some >> getters/setters that are not consistent and >> and have specification that says nothing about how they should be used and >> how do they behave in BasicTreeUI. >> >> Fix : This bug was already sent for review by semyon >> http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/ >> <http://cr.openjdk.java.net/~ssadetsky/7020860/webrev.00/>. >> I have made the following changes to the above webrev : >> * @param newValue the new value of the {@code editable}> property >> changed to —>> >> * @param newValue the new value of the {@code editable} >> property >> >> And >> * Returns whether the root node of the drawn >> tree component is displayable. >> >> changed to —>> >> >> * Returns whether the root node of the drawn >> tree component should be displayed. >> >> >> Regards >> Tejpal >
