Hi Sergey, Thanks for the comments.
I have removed the annotation that ignores the macOS completely and added a check to ignore the validations for Aqua LAF only. The LookandFeel parameter is normally set as part of the test execution as VM arguments, hence not looping through all the available LAF. Kindly review and let me know if there are any comments. JBS:https://bugs.openjdk.java.net/browse/JDK-8235900 Webrev: http://cr.openjdk.java.net/~nnigam/8235900/webrev.1/ Testing: tested with jtreg on mac and other platforms. Thanks, Suresh. -----Original Message----- From: Sergey Bylokhov Sent: Monday, December 23, 2019 12:43 AM To: Sureshkumar Mahaliswamy <sureshkumar.mahalisw...@oracle.com>; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> RFR : [15] : 8235900 : PopupMenu Opaque property is not reflecting the Parents property on MAC OS Hi, Sureshkumar. Probably it will be better to do something instead of completely disabling the test. The problem exists in Aqua, but we can test some other L&F on macOS. I guess the best solution is to iterate over all installed L&fs, but exclude Aqua. On 12/17/19 11:55 am, Sureshkumar Mahaliswamy wrote: > Hi All, > > Kindly review the small patch. > > Added the annotation @requires(os.family!=mac) to ignore the test execution > on MAC,since Aqua LaF forces all popups to be heavyweight. > > Marking this test not to be executed for MAC platform. > > JBS:https://bugs.openjdk.java.net/browse/JDK-8235900 > > Webrev: http://cr.openjdk.java.net/~nnigam/8235900/webrev.0/ > > Testing: tested with jtreg. > > Thanks, > > Suresh. > -- Best regards, Sergey.
