Looks fine, please split the long lines before the push, we
use (at least try to use) 80 chars per line.
On 1/21/20 2:13 am, Sureshkumar Mahaliswamy wrote:
Hi Sergey,
I have modified the test to iterate over all the installed look and feel, but
excluding aqua.
JBS:https://bugs.openjdk.java.net/browse/JDK-8235900
Webrev: http://cr.openjdk.java.net/~nnigam/8235900/webrev.2/
Testing: tested with jtreg.
Kindly review and let me know your thoughts.
Thanks,
Suresh.
-----Original Message-----
From: Sergey Bylokhov
Sent: Monday, January 20, 2020 9:04 AM
To: Sureshkumar Mahaliswamy <sureshkumar.mahalisw...@oracle.com>;
swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> RFR : [15] : 8235900 : PopupMenu Opaque property is
not reflecting the Parents property on MAC OS
On 1/13/20 10:49 pm, Sureshkumar Mahaliswamy wrote:
The LookandFeel parameter is normally set as part of the test
execution as VM arguments, hence not looping through all the available LAF.
This parameter is rarely set, actually never set when the tests are executed via
mach5, I suggest to iterate over the list of L&F in the test since we know that
its behavior can depend on them.
Kindly review and let me know if there are any comments.
JBS:https://bugs.openjdk.java.net/browse/JDK-8235900
Webrev: http://cr.openjdk.java.net/~nnigam/8235900/webrev.1/
Testing: tested with jtreg on mac and other platforms.
Thanks,
Suresh.
-----Original Message-----
From: Sergey Bylokhov
Sent: Monday, December 23, 2019 12:43 AM
To: Sureshkumar Mahaliswamy <sureshkumar.mahalisw...@oracle.com>;
swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> RFR : [15] : 8235900 : PopupMenu Opaque
property is not reflecting the Parents property on MAC OS
Hi, Sureshkumar.
Probably it will be better to do something instead of completely disabling the
test. The problem exists in Aqua, but we can test some other L&F on macOS.
I guess the best solution is to iterate over all installed L&fs, but exclude
Aqua.
On 12/17/19 11:55 am, Sureshkumar Mahaliswamy wrote:
Hi All,
Kindly review the small patch.
Added the annotation @requires(os.family!=mac) to ignore the test execution on
MAC,since Aqua LaF forces all popups to be heavyweight.
Marking this test not to be executed for MAC platform.
JBS:https://bugs.openjdk.java.net/browse/JDK-8235900
Webrev: http://cr.openjdk.java.net/~nnigam/8235900/webrev.0/
Testing: tested with jtreg.
Thanks,
Suresh.
--
Best regards, Sergey.
--
Best regards, Sergey.
--
Best regards, Sergey.
