Hi All,

Please review a fix for an issue where it is seen JOptionPane showInputDialog and showConfirmationDialog in SwingSet2 "OptionPane Demo" dialog

is being shown as a "Java" icon instead of "i" icon for AquaLookAndFeel in mac. Other L&Fs show "i" icon.

Issue is because in Aqua L&F, JOptionPane.informationIcon and JOptionPane.questionIcon uses "confirmIcon" which uses generic java icon as seen here

http://hg.openjdk.java.net/jdk/client/file/9078079d153b/src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java#l53

Proposed fix is to use appropriate icon gif image that is being used for other L&Fs for showInputDialog and showConfirmationDialog.

Other icons like errorIcon and warningIcon is not changed as it uses system icons via AquaIcon.SystemIcon icons but these system-icons are not present for the above 2 icons.

Bug: https://bugs.openjdk.java.net/browse/JDK-8210850

webrev: http://cr.openjdk.java.net/~psadhukhan/8210850/webrev.0/

No regression test is provided as it can be verified through SwingSet2 OptionPane demo.

Regards
Prasanta


Reply via email to