Re: [15] RFR : 8249278 : Revert JDK-8226253 which breaks the spec of AccessibleState.SHOWING for JList

[Philip Race]

+1

-phil

On 7/14/20, 7:44 PM, Ambarish Rapte wrote:

Hello Phil,

Thanks for the review and correcting the mail group,

Please take a look at the updated webrev with © years also backed out:

http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.1 <http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.1>

Regards,

Ambarish.

*From:*Philip Race
*Sent:* Wednesday, July 15, 2020 2:00 AM

*To:* Ambarish Rapte <ambarish.ra...@oracle.com>; swing-dev@openjdk.java.net

*Cc:* awt-...@openjdk.java.net
*Subject:* Re: <AWT Dev> [15] RFR : 8249278 : Revert JDK-8226253

adding swing-dev which is the correct list for this Swing change.

It looks like a faithful backout of
https://bugs.openjdk.java.net/browse/JDK-8226253
https://hg.openjdk.java.net/jdk/jdk/rev/3ea8a0c5c264

except that the (c) year is remaining 2020 .. which I think just
indicates the silliness of all these (c) updates since the only
changes to these files in 2020 were those which you have now backed out.

So I think you should revert the (c) changes as well.

If some one else comes along and updates all files in JDK with updates in 2020

and so re-adds it then that is their problem ...

-phil.

On 7/14/20, 5:37 AM, Ambarish Rapte wrote:

    Hi,

    Please review this fix:

    JBS: https://bugs.openjdk.java.net/browse/JDK-8249278

    Webrev: http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.0/
    <http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.0/>

    This change reverts the fix for JDK-8226253.

    The fix of JDK-8226253 breaks the specification of
    AccessibleState.SHOWING for JList and has caused a regression with
    JTree.

    There is no alternative to fix JDK-8226253 on JDK side and the
    issue should be really fixed on Screen reader side.

    So in order to keep the correctness of spec and avoid any new
    regression, the fix needs to be reverted.

    Regards,

    Ambarish