On 14.08.2020 08:22, Kumar Abhishek wrote:
I have updated the test.
Please find the updated Webrev:
http://cr.openjdk.java.net/~aivanov/kumar.abhishek/8136363/webrev.01/
I think that the test should be marked as headful, otherwise it will fail
on the headless systems, please double-check this via mach5.
Thanks,
Abhishek
-----Original Message-----
From: Sergey Bylokhov
Sent: Friday, July 31, 2020 3:11 AM
To: Kumar Abhishek <kumar.z.abhis...@oracle.com>; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [16] RFR 8136363: Nimbus-LaF: background color cleared
when setting component name of JToolBar
Hi, Kumar.
I suggest improving the test a little bit. The test in the description of the bug
checks all Swing components, it will be useful to do the same. Also, can you please
iterate over all installed L&F and test each.
On 29.07.2020 09:21, Kumar Abhishek wrote:
Hello,
Could you review a fix for jdk16, please?
Webrev: http://cr.openjdk.java.net/~dmarkov/8136363/webrev/
Bug: https://bugs.openjdk.java.net/browse/JDK-8136363
Problem Description:
Nimbus-LaF: background color cleared when setting component name of
JToolbar
Fix:
The updatestyle method of the synthlook&feel is called to update style for the
regions of every component.
In this case ,style for the regions of JToolbar
(*Region.TOOL_BAR_CONTENT*and*Region.TOOL_BAR_DRAG_WINDOW*) was getting cleared
and so the background color was getting cleared.
I have updated the correct style for the regions of JToolbar.
Thanks,
Abhishek
--
Best regards, Sergey.
--
Best regards, Sergey.
