Hi Sergey/Alexey, Thank you for the suggestion. I have added those information to the test. Please find the new Webrev here:- http://cr.openjdk.java.net/~aivanov/kumar.abhishek/8136363/webrev.02/
Thanks, Abhsihek -----Original Message----- From: Alexey Ivanov Sent: Monday, August 17, 2020 11:47 PM To: Sergey Bylokhov <sergey.bylok...@oracle.com>; Kumar Abhishek <kumar.z.abhis...@oracle.com>; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> [16] RFR 8136363: Nimbus-LaF: background color cleared when setting component name of JToolBar On 15/08/2020 06:56, Sergey Bylokhov wrote: > On 14.08.2020 08:22, Kumar Abhishek wrote: >> I have updated the test. >> Please find the updated Webrev: >> http://cr.openjdk.java.net/~aivanov/kumar.abhishek/8136363/webrev.01/ > > I think that the test should be marked as headful, otherwise it will > fail on the headless systems, please double-check this via mach5. Yes, it definitely requires @key headful. I also suggest dropping "Nimbus-LaF" from the description: 27 * @summary Nimbus-LaF: Verifies background color of a component does not change after setting name. The test is not Nimbus specific any more. And the empty line 53 inside main can be removed too: 52 public static void main(String[] args) throws Exception { 53 54 SwingUtilities.invokeAndWait(new Runnable() { > >> Thanks, >> Abhishek >> -----Original Message----- >> From: Sergey Bylokhov >> Sent: Friday, July 31, 2020 3:11 AM >> To: Kumar Abhishek <kumar.z.abhis...@oracle.com>; >> swing-dev@openjdk.java.net >> Subject: Re: <Swing Dev> [16] RFR 8136363: Nimbus-LaF: background >> color cleared when setting component name of JToolBar >> >> Hi, Kumar. >> >> I suggest improving the test a little bit. The test in the >> description of the bug checks all Swing components, it will be useful >> to do the same. Also, can you please iterate over all installed L&F >> and test each. -- Regards, Alexey
