On Sat, 7 Nov 2020 09:02:02 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   use getBounds()
>
> test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 96:
> 
>> 94:                                       
>> getDefaultScreenDevice().getDefaultConfiguration().
>> 95:                                       getBounds();
>> 96:                     locx = rect.width/2;
> 
> The usage of size 300x300 has the same issues as locx/locy before. It is part 
> of the window bounds.

but 300x300 is set in frame setSize..if I use frame getBounds instead of 
already set 300x300, that will not be right, according to me...What if 
getBounds() has some bug (in some platform) and return some other width/height 
(say 1 pixel less, we might have similar bug in 8196465) that what is set in 
setSize, then the test might pass even though robot is capturing wrong bounds.

-------------

PR: https://git.openjdk.java.net/jdk/pull/955

Reply via email to