On Fri, 18 Dec 2020 03:35:03 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> I wouldn't know how to approve an earlier version. SFAIK I approved the >> current version. >> One thing here though is that I think you should WITHDRAW this PR and >> re-submit for JDK 16. >> I don't think we want to have to wait until JDK 17 to be able to read tabs >> on macOS 11. > > The current version has the issue of text color obtained through > [selectedControlColor] being changed through "Preferences->General->Accent > Color", which is not in our control, which was already discussed. So, I > thought the 1st version, which is more robust, is the one which is approved. If you want to go back to the first version, then you will need to revert the changes from the subsequent commits and push a new commit. However, please see Phil's comment above: since this should go into JDK 16, you will need to create a personal fork of jdk16, clone that repo, push your patch to a new branch in that repo, and create a PR from that. ------------- PR: https://git.openjdk.java.net/jdk/pull/1182
