On Fri, 18 Dec 2020 13:00:35 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> The current version has the issue of text color obtained through >> [selectedControlColor] being changed through "Preferences->General->Accent >> Color", which is not in our control, which was already discussed. So, I >> thought the 1st version, which is more robust, is the one which is approved. > > If you want to go back to the first version, then you will need to revert the > changes from the subsequent commits and push a new commit. > > However, please see Phil's comment above: since this should go into JDK 16, > you will need to create a personal fork of jdk16, clone that repo, push your > patch to a new branch in that repo, and create a PR from that. > > The forumpost is here https://discussions.apple.com/thread/252067605 > > The hardcoded being referred was in this 1st iteration of the fix > > https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00 > > OK. So I guess this could work for either light or dark theme but since we > cache the result, if you switch theme whilst JDK is running it won't help - > but we would have a bunch of work to do to support that. It does not cached it is a mutable SystemColor which is updated on the color theme switch, it works in a similar way as text selection color which might be configured in the macOS settings. ------------- PR: https://git.openjdk.java.net/jdk/pull/1182
