On Sun, 20 Dec 2020 20:22:48 GMT, Andrey Turbanov <github.com+741251+turban...@openjdk.org> wrote:
>> jrtfs is compiled twice, the second is to --release 8 so it can be packaged >> into jrt-fs.jar for use by IDEs/tools running on older JDK releases. So need >> to be careful with the changes here as it will likely causing build breakage. >> >> We try to keep the changes to ASM to a minimum, might be better to leave >> this change out of the patch. >> >> One or two of the sources changes should probably uses Files.copy, e.g. >> ZipPath, sjavac/CopyFile.java. > >> One or two of the sources changes should probably uses Files.copy, e.g. >> ZipPath, sjavac/CopyFile.java. > > Good idea! Replaced in few places. But not in ZipPath: it's actually > implementation of underlying call from Files.copy: > `jdk.nio.zipfs.ZipFileSystemProvider#copy`. So, `Files.copy` call will be > recursive. So these changes are all over the place which means no one person knows how to test all of it. Have you run the sound, swing tests, and the printing tests on unix and windows ? For printing for sure you'll need to do some manual testing. ------------- PR: https://git.openjdk.java.net/jdk/pull/1853
