On Sun, 16 May 2021 18:49:24 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Slight change of wording in javadoc
>> Fixed Win32ShellFolder2.getSystemIcon scaling issue
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
> line 271:
>
>> 269: * Example: <pre>
>> 270: * FileSystemView fsv = FileSystemView.getFileSystemView();
>> 271: * Icon icon = fsv.getSystemIcon("application.exe", 64);
>
> Shouldn't the first parameter be a File instance instead of String?
> `Icon icon = fsv.getSystemIcon(new File("application.exe"), 64);`
Good catch! Yes, fixed both here and in CSR.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2875
