On Wed, Apr 8, 2009 at 2:12 PM, Troy A. Griffitts <scr...@crosswire.org> wrote: > Thanks Karl. There have been some changes in verse parsing lately that I'm > not positive we've considered all the repercussions. We need to add some > more tests to our testsuite, specifically versekeytest.cpp to be sure things > operate correctly now and in the future. > > Any chance we can get a simple test added to the top that shows the issue? > It will be a little easier to debug than with diatheke, and will give us a > good mark to be sure we hit with future changes.
It seems pretty straightforward... no one even tested the impact of (at least one of) the latest changes on the library. Karl has spot-checked a number of verses around the Bible from different books, and they all give output for the entire Bible. I don't know if Karl updated from 2303 to 2304, so I can't say that it was version r2304 that made the break, but someone made changes and didn't even bother pulling a Bible verse to check if it was still working. No amount of test suite updates will help if the submitter doesn't even do a manual check with as simple a tool as diatheke (and therefore probably won't be running the test suite). --Greg > > -Troy. > > > > Karl Kleinpaste wrote: >> >> I asked for just one verse. >> >> $ svn info | grep ^Rev >> Revision: 2304 >> $ time ./utilities/diatheke/diatheke -b KJV -k Gen1.1 > /tmp/kjv-gen1.1 >> 61.594u 0.869s 1:02.86 99.3% 0+0k 0+9040io 0pf+0w >> $ wc /tmp/kjv-gen1.1 >> 44123 862024 4628222 /tmp/kjv-gen1.1 >> $ head /tmp/kjv-gen1.1 >> [ Module Heading ]: [ Testament 1 Heading ]: Genesis 0:0: Genesis 1:0: >> Genesis 1:1: In the beginning God created the heaven and the earth. >> Genesis 1:2: And the earth was without form, and void; and darkness was >> upon the face of the deep. And the Spirit of God moved upon the face of the >> waters. >> Genesis 1:3: And God said, Let there be light: and there was light. >> Genesis 1:4: And God saw the light, that it was good: and God divided the >> light from the darkness. >> Genesis 1:5: And God called the light Day, and the darkness he called >> Night. And the evening and the morning were the first day. > > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page > _______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
