Hi Tristan, I've been playing around with the sfActAsNestedSetBehavior plugin. Thanks for publishing this plugin. I've got some questions, commments and a possible bug.
1) Why should MakeRoot() only work for new Propel objects? (see line 222) I disabled this in my application because I need the ability to turn existing objects into root nodes. However, I am curious why this MakeRoot() has this requirement. Is it because you were working from the perspective of a Forum application where only new posts should become a root or am I missing something? 2) Maybe getDescendants() should return null if isLeaf($node) is true. Otherwise getDescendants() causes a dbase crash because of empty TREE_LEFT & TREE_RIGHT values. I know you can check for that in your code before you call getDescendants() but it it might be a little more efficient to move it down to sfActAsNestedSetBehavior. 3) Both InsertAsFirstChildOF() and InsertAsLastChildOf() are acting buggy in my tests. I am not able to pin down exactly what is happening but generally the problem occurs when I start adding grandchildren, then either the parent or one or more of the aunt/uncles(?) get assigned right values that are outside of the scope of the tree (i.e. greater than the right value of the root node). Have you or anyone else experienced this? 4) Is there support for moving/deleting sub-trees? i.e, if I move a node to a new branch will its descendants also move to that branch? Or if I delete a node will its children get adopted by their grandparent? Cheers, --peterVG --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
