Hi, On 3/21/07, Peter Van Garderen <[EMAIL PROTECTED]> wrote:
> > 1) Why should MakeRoot() only work for new Propel objects? (see line 222) > I > disabled this in my application because I need the ability to turn > existing > objects into root nodes. However, I am curious why this MakeRoot() has > this > requirement. Is it because you were working from the perspective of a > Forum > application where only new posts should become a root or am I missing > something? +1 2) Maybe getDescendants() should return null if isLeaf($node) is true. > Otherwise getDescendants() causes a dbase crash because of empty TREE_LEFT > & > TREE_RIGHT values. I know you can check for that in your code before you > call getDescendants() but it it might be a little more efficient to move > it > down to sfActAsNestedSetBehavior. +1 3) Both InsertAsFirstChildOF() and InsertAsLastChildOf() are acting buggy in > my tests. I am not able to pin down exactly what is happening but > generally > the problem occurs when I start adding grandchildren, then either the > parent > or one or more of the aunt/uncles(?) get assigned right values that are > outside of the scope of the tree (i.e. greater than the right value of the > root node). Have you or anyone else experienced this? could you provide unit tests demonstrating this problem ? 4) Is there support for moving/deleting sub-trees? i.e, if I move a node to > a new branch will its descendants also move to that branch? Or if I delete > a > node will its children get adopted by their grandparent? This is supposed to work. i will modify code according to your suggestions (1 & 2) and publish a new release. If you can provide unit tests for 3 soon enough i'll try to include the fix along. thanks for taking the time to think about all this :) ++ tristan --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
