Lukas Kahwe Smith wrote:
> OrangeD wrote:
>
>
>> I like the shaving very much, but I would recommend not to include it
>> in the plugin until this option is also provided by the GD Adapter.
>>
>
> Well since I am quite sure that the feature could be added to the GD
> adapter (which is where I need this) can be extended to get this feature
> with the same API, I think its fine to just add it in. This will
> encourage someone else (maybe me) to add it to the GD driver eventually
>
>
>> Using external image files can be pretty helpful, indeed - but I'm not
>> sure if it should be included. It's a potential security issue and I'm
>> not sure at all whether this belongs to the job of a thumbnail plugin.
>> Additionally, I think it won't work on many (shared hosting) machines
>> at all.
>>
>
> I also do not see why this makes sense. Its easy enough to read the
> contents of a remote file and pass it to the current API via loadData()
>
> regards,
> Lukas
>
> >
>
>
Hmm, while I can see why you would not want to use a URL for the souce
image, I cannot see how this is a security issue. Somebody wants to
elaborate? Likas, isn't it easy enough to do it yourself exec("convert
-thumbnail 150x150 source.jpg output.jpg")? So the argument that is is
easy enough to read a remote file and pass it as an argument does not
fly for me. You can have many different ways to download a remote file
depending on if the PHP function like fopen() file_get_contents() are
allowed by the php.ini setting to do so, it is a windows machine then
maybe there is an alternative to 'wget', etc. You get the point. Isn't
that the point of using a libraries, frameworks... I would agree that my
implementation of getting the file is not optimal and maybe I can do it
with some of the symfony's file handling classes (I have to look if
there is/are such) it is in no way security problem. Please, prove me
wrong :)
About the why one thing is supported by the sfImageMagick adapter and
not by the GD one - this did not stop from implementing toString() for
the GD adapter and not for the ImageMagick, right?
Think about flickr, amazon, etc where you get the image src as a URL
(using their APIs) so it makes sense for me for the sfThumbnailPlugin to
support that out of the box and not have the user do any other work in
order to handle those cases. I am using the URL as as source with
Amazon, for example, just to avoid comments like who will do that at all :)
Best,
Kupo
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---
