When i read again my message, this is very rude. Not very adapted for an free open-source project. If you need help on correcting your patch, I can send more info on my crash, what do you need most ?
On 4 avr, 17:11, "noel guilbert" <[EMAIL PROTECTED]> wrote: > Hello, > > I'm really sorry for the annoyance, and I've reverted this change to the > revision r7757. > > Be sure, I've tested this patch before commit it, and I haven't see any bugs > in my environnement. And promise, I'll test my futures patches two, three, > or even ten times if it's needed. > > And again, excuse me. > > On Fri, Apr 4, 2008 at 4:32 PM, [EMAIL PROTECTED] <[EMAIL PROTECTED]> > wrote: > > > > > > > Many thanks for your "fix", i didn't have your bug on Windows, and > > since you "fixed" it nothing works on my project... Now I must use a "- > > r 8190" in my svn:externals so that my project can work... > > Please *test* before making commits to the trunk, this is *very* > > annoying to have such an unexpected bug : I lost only one hour before > > I understood who was guilty (you) but I could have lost *very* more > > time. > > > Please check again your patch, because this is not working at all. As > > a proof, please look at this : > > > - [EMAIL PROTECTED] :http://b.imagehost.org/view/0389/Clipboard01.png > > - [EMAIL PROTECTED] :http://b.imagehost.org/view/0389/Clipboard02.png > > > Note : between 8190 & 8288, there are only noel's commits >< > > Note2 : there is nothing special in my admin generators, nor in my > > config, and before your "fixes" it worked perfecly on Windows & Linux > > (on 5 different machines to tell everything). > > > On 4 avr, 11:17, "noel guilbert" <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > fixed in r8254 <http://trac.symfony-project.com/changeset/8254> > > > > On Tue, Apr 1, 2008 at 12:31 AM, Joe Kelsey <[EMAIL PROTECTED]> wrote: > > > > > sfFinder cannot do relative searches on at least Windoze. > > > > > Whenever you regularize directory names, then all directory names end > > > > with DIRECTORY_SEPARATOR. Then, in search_in() the stripping of > > > > directories fails: > > > > > $files = array_merge($files, > > > > str_replace($dir.DIRECTORY_SEPARATOR, '', $this->search_in($dir))); > > > > > In this case, $dir already ends with DIRECTORY_SEPARATOR, so the > > > > str_replace ALWAYS fails since $dir.DIRECTORY_SEPARATOR produces two > > > > concatenated DIRECTORY_SEPARATORs. So, I simply removed the > > > > catenation of DIRECTORY_SEPARATOR. The REAL solution is to either > > > > make sure the $dir string ahs no terminating DIRECTORY_SEPARATOR or > > > > else that you specifically remove it. > > > > > /Joe > > > > -- > > > Noël GUILBERThttp://www.sensiolabs.comhttp://www.symfony-project.com > > > Sensio Labs > > > Tél: +33 1 40 99 80 80 > > -- > Noël GUILBERThttp://www.sensiolabs.comhttp://www.symfony-project.com > Sensio Labs > Tél: +33 1 40 99 80 80 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
