On Apr 4, 1:17 am, "noel guilbert" <[EMAIL PROTECTED]> wrote:
> Hello,
>
> fixed in r8254 <http://trac.symfony-project.com/changeset/8254>
This is really very confusing. Your proposed "fix" does not seem to
address the given problem. You need to explore the system and find
out exactly why the $dir always (or only sometimes) has
DIRECTORY_SEPARATOR appended to its value and exactly when you should
either append or not append it. Is there some difference in the
windoze versus linux directory calls? Your fix completely throws away
the DIRECTORY_SEPARATOR usage and uses just '/' and '\\', which seems
wrong.
I am confused.
/Joe
> On Tue, Apr 1, 2008 at 12:31 AM, Joe Kelsey <[EMAIL PROTECTED]> wrote:
>
> > sfFinder cannot do relative searches on at least Windoze.
>
> > Whenever you regularize directory names, then all directory names end
> > with DIRECTORY_SEPARATOR. Then, in search_in() the stripping of
> > directories fails:
>
> > $files = array_merge($files,
> > str_replace($dir.DIRECTORY_SEPARATOR, '', $this->search_in($dir)));
>
> > In this case, $dir already ends with DIRECTORY_SEPARATOR, so the
> > str_replace ALWAYS fails since $dir.DIRECTORY_SEPARATOR produces two
> > concatenated DIRECTORY_SEPARATORs. So, I simply removed the
> > catenation of DIRECTORY_SEPARATOR. The REAL solution is to either
> > make sure the $dir string ahs no terminating DIRECTORY_SEPARATOR or
> > else that you specifically remove it.
>
> > /Joe
>
> --
> Noël GUILBERThttp://www.sensiolabs.comhttp://www.symfony-project.com
> Sensio Labs
> Tél: +33 1 40 99 80 80
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---
