2008/12/5 Jan Markmann <[EMAIL PROTECTED]>

>
> I am about to plan Continious Integration for you development process
> (that includes symfony) and thus was looking for symfony coding
> standards implemented for PHP_CodeSniffer as it is used by
> phpUnderControl.
> I found an implementation in the qubit-toolkit svn repository inside
> their (unpublished) sfAuditPlugin.
> Find it here:
> http://qubit-toolkit.googlecode.com/svn/trunk/qubit/plugins/sfAuditPlugin/lib/vendor/PHP/CodeSniffer/Standards
> I ran it again a symfony example project and it threw quite some
> errors and warnings.
> Well, looks like the PHP_CodeSniffer Standard-implementation is not
> that perfect and checks rules that do not apply to symfony, but so far
> I found only one: control structures in templates throw errors since
> they have a different standard then thoose in regular PHP code and
> only the regular style is taken into account.
> There other errors reported whos subject is not clearly defined in the
> symfony wiki page about coding standard so its hard to tell if the
> underlying rules are needless or symfony's code really has some coding
> standard violations. Such are rules about whitespaces or usage of
> double quotes if not needed.
> What do you think about integrating this PHP_CodeSniffer standard into
> symfony and thus improving enforcement of symfony's coding standards?


+1, not really to check the symfony core but to check the code done in apps
and libs

Olivier



>
> Perhaps one of the core team members could run it again symfony libs
> and give an opinion.
> >
>


-- 
Olivier Mansour
[EMAIL PROTECTED]
http://www.glagla.org

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/symfony-devs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to