hi, Kiril Angov: Before I know PHP_CodeSniffer and phpUnderControl, I had make a command line tool for checking my code standard, and I didn't ever make plug-in for Symfony before, just would be my first test plug-in.
On Tue, Dec 9, 2008 at 7:37 PM, Kiril Angov <[EMAIL PROTECTED]> wrote: > > I guess you did not really read the first post of this thread :) > > http://qubit-toolkit.googlecode.com/svn/trunk/qubit/plugins/sfAuditPlugin > > On Tue, Dec 9, 2008 at 1:17 PM, Sam Ma <[EMAIL PROTECTED]> wrote: > > > > > > On Tue, Dec 9, 2008 at 2:17 AM, Kiril Angov <[EMAIL PROTECTED]> > wrote: > >> > >> http://trac.symfony-project.com/trac/wiki/CodingStandards > >> > >> On Mon, Dec 8, 2008 at 7:23 PM, Sam Ma <[EMAIL PROTECTED]> wrote: > >> > Does Symfony have code standard? > >> > > >> > On Mon, Dec 8, 2008 at 11:39 PM, Stefan Koopmanschap > >> > <[EMAIL PROTECTED]> wrote: > >> >> > >> >> Hi, > >> >> > >> >> My work on the integration of lime and phpUnderControl is currently > on > >> >> hold as I help on the jobeet project. As soon as Jobeet is done, I > >> >> plan to continue my work on it. > >> >> > >> >> Stefan > >> >> > >> >> On Mon, Dec 8, 2008 at 9:38 AM, Kiril Angov <[EMAIL PROTECTED]> > >> >> wrote: > >> >> > > >> >> > Yes, does anybody have any progress on CI setup? thanks for the > >> >> > sfAuditPlugin link, btw. > >> >> > > >> >> > On Sat, Dec 6, 2008 at 5:19 PM, Stefan Koopmanschap > >> >> > <[EMAIL PROTECTED]> wrote: > >> >> >> > >> >> >> First of all, having a standards file would be great (plugins > could > >> >> >> even be tested against it!). > >> >> >> > >> >> >> Second of all, since i've been working on symfony integration for > >> >> >> phpUnderControl, I'd be very interested in if you are using lime > or > >> >> >> phpUnit for your CI setup. > >> >> >> > >> >> >> Sincerely, > >> >> >> > >> >> >> Stefan > >> >> >> > >> >> >> On Fri, Dec 5, 2008 at 4:20 PM, Jan Markmann <[EMAIL PROTECTED]> > wrote: > >> >> >>> > >> >> >>> I am about to plan Continious Integration for you development > >> >> >>> process > >> >> >>> (that includes symfony) and thus was looking for symfony coding > >> >> >>> standards implemented for PHP_CodeSniffer as it is used by > >> >> >>> phpUnderControl. > >> >> >>> I found an implementation in the qubit-toolkit svn repository > >> >> >>> inside > >> >> >>> their (unpublished) sfAuditPlugin. > >> >> >>> Find it here: > >> >> >>> > >> >> >>> > http://qubit-toolkit.googlecode.com/svn/trunk/qubit/plugins/sfAuditPlugin/lib/vendor/PHP/CodeSniffer/Standards > >> >> >>> I ran it again a symfony example project and it threw quite some > >> >> >>> errors and warnings. > >> >> >>> Well, looks like the PHP_CodeSniffer Standard-implementation is > not > >> >> >>> that perfect and checks rules that do not apply to symfony, but > so > >> >> >>> far > >> >> >>> I found only one: control structures in templates throw errors > >> >> >>> since > >> >> >>> they have a different standard then thoose in regular PHP code > and > >> >> >>> only the regular style is taken into account. > >> >> >>> There other errors reported whos subject is not clearly defined > in > >> >> >>> the > >> >> >>> symfony wiki page about coding standard so its hard to tell if > the > >> >> >>> underlying rules are needless or symfony's code really has some > >> >> >>> coding > >> >> >>> standard violations. Such are rules about whitespaces or usage of > >> >> >>> double quotes if not needed. > >> >> >>> What do you think about integrating this PHP_CodeSniffer standard > >> >> >>> into > >> >> >>> symfony and thus improving enforcement of symfony's coding > >> >> >>> standards? > >> >> >>> Perhaps one of the core team members could run it again symfony > >> >> >>> libs > >> >> >>> and give an opinion. > >> >> >>> > > >> >> >>> > >> >> >> > >> >> >> > > >> >> >> > >> >> > > >> >> > > > >> >> > > >> >> > >> >> > >> > > >> > > >> > > > >> > > >> > >> > > > > Great, I would try to make a simple plugin for checking code standard. > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
