On Mar 5, 2009, at 5:54 PM, Thomas Rabaix wrote: > Hello, > > Point 1 : > I think symfony generates to many classes : Form and Filter. I will > prefer to generates this class only when required, having less class > cannot be bad.
I recently filed a ticket for this: http://trac.symfony-project.org/ticket/4822 > Point 2 : > Next, It is bad to generate project wide form/filter classes as > depends on the application validation maybe changes : admin can have > more control over the form. So the generator have to generate 3 files > BaseYourModelForm.class.php : file with the basic widget definition > as now > SharedYourModelForm.class.php : the dev can globally overwrite > definition from BaseYourModelForm (acts like the current > YourModelForm) > YourModelForm : inside the application lib This seems to go against your first point. Why not extend the normal form for the more specialized cases on a personal "need to" bases...? -1 for me > Point 3 : > Model Form should have a method to define which fields we want to > use. This will avoid bugs when adding new field into the model, as > the base form will use them on update. > Ehm, I'm not sure what you want to achieve, currently you can just do that by un/setting the appropriate widgets and validators right...? > > > -- > Thomas Rabaix > http://rabaix.net > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
