Right, at any rate the idea you propose is a new feature and 1.4 is frozen.
- Jon On Sun, Aug 29, 2010 at 5:01 PM, Tom Boutell <[email protected]> wrote: > Well, okay, dependency injection in general I suppose.But that's not > how Symfony 1.4 does things, alas. > > On Sun, Aug 29, 2010 at 5:56 PM, Jonathan Wage <[email protected]> wrote: > > In my opinion because it would be making the same mistake twice. The > models > > and forms generating all these base classes is just crazy and was a > mistake. > > Which is why you don't really see anything like that in Symfony2 and > > Doctrine2. So that's why I would vote against it, it makes my stomach > cringe > > from a maintenance and complexity perspective. > > - Jon > > > > On Sat, Aug 28, 2010 at 7:37 AM, Tom Boutell <[email protected]> wrote: > >> > >> This approach could work but doesn't help you if you want to change > >> the behavior of every time widget, Doctrine and otherwise. An > >> overrideable class does do that. Every model class in a Symfony > >> application is overrideable in this way. I don't get why it's bad news > >> to make the widgets overrideable in this way too. > >> > >> On Sat, Aug 28, 2010 at 8:36 AM, Tom Boutell <[email protected]> wrote: > >> > Eesh! This is the easy way? (: > >> > > >> > On Fri, Aug 27, 2010 at 3:12 PM, Kris Wallsmith > >> > <[email protected]> wrote: > >> >> Providing a --generator-class option to the :build-forms task would > >> >> work, > >> >> but listening to the command.filter_options event is probably a > better > >> >> idea > >> >> since that option isn't available on the :build task. > >> >> > >> >> Kris > >> >> -- > >> >> Kris Wallsmith | Release Manager > >> >> [email protected] > >> >> Portland, Oregon USA > >> >> http://twitter.com/kriswallsmith > >> >> On Aug 27, 2010, at 11:55 AM, Tom Boutell wrote: > >> >> > >> >> sfDoctrineFormGenerator has lots of code and is not an empty override > >> >> of a Base class. So I have to either copy it, which is definitely not > >> >> surgical, or figure out how to tell Doctrine to use my class instead. > >> >> How would I do that? > >> >> > >> >> On Fri, Aug 27, 2010 at 1:30 PM, Kris Wallsmith > >> >> <[email protected]> wrote: > >> >> > >> >> No need to reinvent the wheel. You just need to extend > >> >> > >> >> sfDoctrineFormGenerator and override getWidgetClassForColumn(). Very > >> >> > >> >> surgical. > >> >> > >> >> Kris > >> >> > >> >> -- > >> >> > >> >> Kris Wallsmith | Release Manager > >> >> > >> >> [email protected] > >> >> > >> >> Portland, Oregon USA > >> >> > >> >> http://twitter.com/kriswallsmith > >> >> > >> >> On Aug 27, 2010, at 9:52 AM, Tom Boutell wrote: > >> >> > >> >> Kris, an example would help. How practical is it really to change the > >> >> > >> >> form generator without reinventing the wheel much? > >> >> > >> >> On Thu, Aug 26, 2010 at 8:24 PM, Kris Wallsmith > >> >> > >> >> <[email protected]> wrote: > >> >> > >> >> Hi guys, > >> >> > >> >> I think the correct approach here is to create a custom form > generator, > >> >> > >> >> right? We won't be creating all these base classes in the core. > >> >> > >> >> Unless I'm not understanding correctly? > >> >> > >> >> Thanks, > >> >> > >> >> Kris > >> >> > >> >> -- > >> >> > >> >> Kris Wallsmith | Release Manager > >> >> > >> >> [email protected] > >> >> > >> >> Portland, Oregon USA > >> >> > >> >> http://twitter.com/kriswallsmith > >> >> > >> >> On Aug 26, 2010, at 2:13 PM, Gustavo Adrian wrote: > >> >> > >> >> +1. Nice idea. > >> >> > >> >> On Thu, Aug 26, 2010 at 6:06 PM, Daniel Lohse > >> >> <[email protected]> > >> >> > >> >> wrote: > >> >> > >> >> +1 > >> >> > >> >> Kris is probably the right person to ask? > >> >> > >> >> > >> >> Cheers, Daniel > >> >> > >> >> Sent from my iPhone4 > >> >> > >> >> On Aug 26, 2010, at 9:11 PM, Tom Boutell <[email protected]> wrote: > >> >> > >> >> Shouldn't these have Base classes so we can override at project level > >> >> > >> >> and have that automatically respected by doctrine and propel forms? > >> >> > >> >> That is: > >> >> > >> >> sfWidgetFormInputText -> BasesfWidgetFormInputText, with > >> >> > >> >> sfWidgetFormInputText an empty wrapper extending that > >> >> > >> >> Then if you define sfWidgetFormInputText at the project level, also > >> >> > >> >> subclassing the Base class but also adding functionality, that wins. > >> >> > >> >> Just like BaseForm. > >> >> > >> >> Makes it drastically easier to enhance the widgets especially those > >> >> > >> >> that don't have any outer wrapper element to hang your CSS and JS on > >> >> > >> >> (time and date especially). > >> >> > >> >> Also you can choose to extend some other subclass that's in a plugin, > >> >> > >> >> so it's easy to reuse other people's enhancements to the stock > >> >> > >> >> widgets. > >> >> > >> >> The base classes can autoload, so no need for crazy require > statements. > >> >> > >> >> Should be a backwards compatible change. > >> >> > >> >> This compares favorably with the complexity of configuring the > >> >> > >> >> doctrine factories to use different widgets, plus that wouldn't help > >> >> > >> >> with any instances not created by Doctrine. > >> >> > >> >> -- > >> >> > >> >> Tom Boutell > >> >> > >> >> P'unk Avenue > >> >> > >> >> 215 755 1330 > >> >> > >> >> punkave.com > >> >> > >> >> window.punkave.com > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> > >> >> to security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> > >> >> Tom Boutell > >> >> > >> >> P'unk Avenue > >> >> > >> >> 215 755 1330 > >> >> > >> >> punkave.com > >> >> > >> >> window.punkave.com > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> -- > >> >> > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> > >> >> Groups "symfony developers" group. > >> >> > >> >> To post to this group, send email to [email protected] > >> >> > >> >> To unsubscribe from this group, send email to > >> >> > >> >> [email protected]<symfony-devs%[email protected]> > >> >> > >> >> For more options, visit this group at > >> >> > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> > >> >> > >> >> > >> >> -- > >> >> Tom Boutell > >> >> P'unk Avenue > >> >> 215 755 1330 > >> >> punkave.com > >> >> window.punkave.com > >> >> > >> >> -- > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> Groups "symfony developers" group. > >> >> To post to this group, send email to [email protected] > >> >> To unsubscribe from this group, send email to > >> >> [email protected]<symfony-devs%[email protected]> > >> >> For more options, visit this group at > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> >> -- > >> >> If you want to report a vulnerability issue on symfony, please send > it > >> >> to > >> >> security at symfony-project.com > >> >> > >> >> You received this message because you are subscribed to the Google > >> >> Groups "symfony developers" group. > >> >> To post to this group, send email to [email protected] > >> >> To unsubscribe from this group, send email to > >> >> [email protected]<symfony-devs%[email protected]> > >> >> For more options, visit this group at > >> >> http://groups.google.com/group/symfony-devs?hl=en > >> >> > >> > > >> > > >> > > >> > -- > >> > Tom Boutell > >> > P'unk Avenue > >> > 215 755 1330 > >> > punkave.com > >> > window.punkave.com > >> > > >> > >> > >> > >> -- > >> Tom Boutell > >> P'unk Avenue > >> 215 755 1330 > >> punkave.com > >> window.punkave.com > >> > >> -- > >> If you want to report a vulnerability issue on symfony, please send it > to > >> security at symfony-project.com > >> > >> You received this message because you are subscribed to the Google > >> Groups "symfony developers" group. > >> To post to this group, send email to [email protected] > >> To unsubscribe from this group, send email to > >> [email protected]<symfony-devs%[email protected]> > >> For more options, visit this group at > >> http://groups.google.com/group/symfony-devs?hl=en > > > > > > > > -- > > Jonathan H. Wage > > http://www.twitter.com/jwage > > > > -- > > If you want to report a vulnerability issue on symfony, please send it to > > security at symfony-project.com > > > > You received this message because you are subscribed to the Google > > Groups "symfony developers" group. > > To post to this group, send email to [email protected] > > To unsubscribe from this group, send email to > > [email protected]<symfony-devs%[email protected]> > > For more options, visit this group at > > http://groups.google.com/group/symfony-devs?hl=en > > > > > > -- > Tom Boutell > P'unk Avenue > 215 755 1330 > punkave.com > window.punkave.com > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected]<symfony-devs%[email protected]> > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- Jonathan H. Wage http://www.twitter.com/jwage -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
