You have a great point about third party code suddenly thinking intl is really available.
I guess we are doing the right thing by creating wrappers then. On Jan 26, 2:23 am, Bernhard Schussek <[email protected]> wrote: > 2011/1/26 Tom Boutell <[email protected]>: > > > Bernhard, wouldn't your solution impose a performance penalty and > > extra maintenance by forcing a bunch of PHP wrapper object calls onto > > everything? > > I don't think the performance penalty is very big. The methods just > contain the delegated method call, like > > public function getDefault() > { > return $this->impl->getDefault(); > > } > > I would think that the solution that I proposed would be better for > > performance reasons and because one doesn't have to remember to use > > the wrappers. > > I see serious problems with this solution. For instance, if some > external library depends on intl, it will use our implementation in > cases where intl is not installed. Since we only implement a subset of > intl, this will lead to weird and hard-to-debug problems. > > Bernhard > -- > Software Architect & Engineer > Blog:http://webmozarts.com > Twitter:http://twitter.com/webmozart -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
