On 02/18/2011 01:13 AM, Jeremy Mikola wrote:
It's certainly advantageous to commit early and often while developing,
but when the time comes to submit a pull request we should reduce things
to logical units. I also feel the rebasing is best done *by the author*
rather than Fabien. Merging/rebasing pull requests is tedious work, and
I'm sure his time is better spent on other tasks (like inspecting the
code :).
My point was that rebasing should only be used if no clean merge will be
possible because major changes relevant to the pull request have taken
place. So yes, the author should do so, but often it will should not be
necessary at all.
If we ask people to rebase their work before I can merge, it won't work
well. Due to the activity we have, the chances that you will have a
clean merge are minimal. So, I will keep asking for a rebase of pull
requests.
Fabien
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
