On 18.02.2011 07:54, Fabien Potencier wrote: > On 2/18/11 12:56 AM, Nils Adermann wrote: >> - Squashing commits of multiple authors drops authorship information, >> since a commit can only ever have one commiter and one author. Having >> our names listed as contributors is one of the few rewards for >> contributing, so losing this information can come us a disappointment. > > It has never happened. Nobody ever loosed authorship. I'm very picky on > this one. I bet you cannot find a single example in Symfony?
In the early Serializer introduction, Nils had a few commits in my branch that got all squashed into "Added Serializer Component" - he still has @author tags though, but it's not something that never happened :) > Right now, I'm very understanding with pull requests. But I can enforce > the rules more often. In that case, I can tell you that more than half > of the pull requests will need some kind of rework from their author. Yeah given the git learning curve I guess we want to cut people some slack if we don't want to lose contributors. But writing a good doc would definitely go a long way, so at least you can point to it even if you merge a "bad" PR, and maybe next time it's better. Cheers -- Jordi Boggiano @seldaek :: http://seld.be/ -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
