I'm not comfortable with the idea of removing flash messages only after they're read. This could lead to unexpected behavior if you change the part of the application that reads a flash message and are checking if a flash message exists in another part of the application, for example.
The expected behavior is for flash message to be available for the next request and the next request only. We just need to exclude certain internal requests. k On Friday, February 25, 2011 at 6:44 AM, John Wards wrote: > On Fri, Feb 25, 2011 at 2:25 PM, Kris Wallsmith > <[email protected]> wrote: > > I'm not sure I understand your patch. What is the nature of changing "old" > > to "read"? > > The point is that flash messages persist until they are read out. So > if you never call getFlash('foo') the foo message will remain in your > session until it is destroyed. > > I don't see the use of a flash message you set and don't read. > > My implementation was just a quick proof of concept, so will need more > thinking and input if it is to go anywhere. > > > The solution that appeals to me is a special request attribute that prevents > > flash messages from being deleted for the duration of that request. This way > > we can specify that a request should not delete flash message simply by > > adding a default value to the route. I'm not sure what the name of that > > attribute would be… _internal? > > I like this idea if the "read state" idea is knocked on the head. > > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
