On Friday, February 25, 2011 at 7:00 AM, John Wards wrote: On Fri, Feb 25, 2011 at 2:48 PM, Kris Wallsmith > <[email protected]> wrote: > > I'm not comfortable with the idea of removing flash messages only after > > they're read. This could lead to unexpected behavior if you change the part > > of the application that reads a flash message and are checking if a flash > > message exists in another part of the application, for example. > > Its removed in the next request is my implementation. So you can read > it lots of times in that request. > > I'm not bothered either way tbh, just can't think of a case where you > would set a flash message then not read it? > > I can see having flash messages lasting a couple of requests being useful. > > > The expected behavior is for flash message to be available for the next > > request and the next request only. We just need to exclude certain internal > > requests. > > Yes but this seems a bit of a hack, I guess its come about with the > ajax implementation of the profiler toolbar. > > Are there other internal requests, or is this just a fix for the toolbar? In AsseticBundle you have the option of serving your assets via a controller during development. If your session is auto-start, I think this will have the side-effect of clearing flash messages, but I haven't confirmed. This would probably be another case for using this request attribute.
Kris > -- > If you want to report a vulnerability issue on symfony, please send it to > security at symfony-project.com > > You received this message because you are subscribed to the Google > Groups "symfony developers" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/symfony-devs?hl=en > -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
